-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-381 | Replace dummy text in APP EXPLANATION
on Apple Watch
#384
ISSUE-381 | Replace dummy text in APP EXPLANATION
on Apple Watch
#384
Conversation
NSHealth{ClinicalHealthRecordsShare,Share,Update}UsageDescription
valuesAPP EXPLANATION
on Apple Watch
@@ -3,11 +3,11 @@ | |||
<plist version="1.0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we delete this file? Will the watch app pick these translations automatically? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but I remember when it was needed to add this file, hence I would suggest not to delete it. Speaking of translations, you didn't add the English source strings for the localization.
Hi, the suggested changes are not quite how these strings are meant to be. Please see some examples here: iAPS/FreeAPS/Resources/Info.plist Line 77 in cb67cbe
These strings are presented tu the user when the app requests permissions. The idea is that the app is transparent about why it wants you to give permissions, such as collect sensitive health data or usage of capabilities like bluetooth. For an app to pass AppStore review (not relevant for us), these things can typically be a blocker unless its done properly. Documentation is available here: |
It looks ok, but you just need to create the localizable strings also. If you create the English source file with strings first you after that can just check all languages for all of the other files to also be created in Xcode. I can help you with this next week after Christmas. |
Please check out this PR: #670 |
#381
Blocked by
Changes
Bla bla {Record,Share,Update}
text withFor the iAPS app to work on the Apple Watch, please ensure that you have enabled HealthKit permissions.