Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-381 | Replace dummy text in APP EXPLANATION on Apple Watch #384

Conversation

bashjs
Copy link
Contributor

@bashjs bashjs commented Nov 24, 2023

#381

Blocked by

Changes

  • Replaced Bla bla {Record,Share,Update} text with For the iAPS app to work on the Apple Watch, please ensure that you have enabled HealthKit permissions.

@bashjs bashjs changed the title ISSUE-381 | Replace dummy text in NSHealth{ClinicalHealthRecordsShare,Share,Update}UsageDescription values ISSUE-381 | Replace dummy text in APP EXPLANATION on Apple Watch Nov 24, 2023
@@ -3,11 +3,11 @@
<plist version="1.0">
Copy link
Contributor Author

@bashjs bashjs Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we delete this file? Will the watch app pick these translations automatically? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but I remember when it was needed to add this file, hence I would suggest not to delete it. Speaking of translations, you didn't add the English source strings for the localization.

@bjornoleh
Copy link
Contributor

Hi, the suggested changes are not quite how these strings are meant to be. Please see some examples here:

<key>NSHealthShareUsageDescription</key>

These strings are presented tu the user when the app requests permissions. The idea is that the app is transparent about why it wants you to give permissions, such as collect sensitive health data or usage of capabilities like bluetooth. For an app to pass AppStore review (not relevant for us), these things can typically be a blocker unless its done properly.

Documentation is available here:
https://developer.apple.com/documentation/bundleresources/information_property_list/nshealthupdateusagedescription

@Jon-b-m
Copy link
Member

Jon-b-m commented Dec 22, 2023

It looks ok, but you just need to create the localizable strings also. If you create the English source file with strings first you after that can just check all languages for all of the other files to also be created in Xcode. I can help you with this next week after Christmas.

@Jon-b-m
Copy link
Member

Jon-b-m commented May 10, 2024

Please check out this PR: #670
and test if this fixes it for you?

@bashjs bashjs closed this Aug 6, 2024
@bashjs bashjs deleted the issue-381/update-app-explanation-on-apple-watch branch August 6, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants