-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jules - various #295
Merged
Merged
Jules - various #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pip._internal.req is not always available. Instead we parse requirements.txt by hand.
JorjMcKie
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have looked through it and haven't seen problems.
I think we should let @green also review it and approve after that (if not too urgent / time permitting).
Avoid treating bullet-lists as tables. The main change is in pdf2docx/layout/Blocks.py:Blocks.collect_stream_lines(). Other: Added fitz.TEXT_CID_FOR_UNKNOWN_UNICODE to flags passed to PyMuPDF's get_text(). New setting `raw_exceptions`, propogates Python exceptions instead of just generating a diagnostic. New setting `sort`, passed to PyMuPDF's get_text(). pdf2docx/table/Cell.py: use hasattr() as workaround to avoid error when no `.is_text_block` member.
Specifically we automate conversion of .docx files to .pdf. We use docx2pdf on Windows (requires Word), Libreoffice on other platforms. Updated expected sidx_required values for libreoffice. Define separate pytest test for each sample file, using @pytest.mark.parametrize.
Default is true, which avoids treating bullet lists as tables.
Currently known to fail.
julian-smith-artifex-com
force-pushed
the
jules
branch
from
June 5, 2024 10:59
8e28518
to
c2459c1
Compare
Have force-pushed a small change to add a fixme note about new use of hasattr(), after comment by robin. |
julian-smith-artifex-com
requested review from
dothinking and
greendreamer
and removed request for
dothinking
June 6, 2024 12:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.