Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui/user): rename nick to name in LocalUser data structure #961

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

qwqcode
Copy link
Member

@qwqcode qwqcode commented Aug 28, 2024

To ensure consistency in data transmission and interaction across different projects and components, we are unifying the LocalUser data structure by renaming nick to name, changing isAdmin to is_admin, and updating the classname of the user nickname element in the comment box from atk-nick to atk-name (the name attribute has also been modified). This change may impact CSS stylesheets. Additionally, projects dependent on the Artalk front-end client API may be affected. We have renamed the nick and isAdmin fields in the LocalUser type interface and updated nick to name and isAdmin to is_admin in LocalStorage.

@qwqcode qwqcode merged commit 392b6b1 into master Aug 28, 2024
9 of 11 checks passed
@qwqcode qwqcode deleted the refactor/user branch August 28, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant