chore(plugins): fix window not defined issue for plugin-kit

ArtalkJS · May 30, 2024 · 822a85c · 822a85c
1 parent 630a3b1
commit 822a85c
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 17 deletions.
diff --git a/docs/docs/package.json b/docs/docs/package.json
@@ -21,7 +21,7 @@
     "vitepress": "1.1.4"
   },
   "dependencies": {
-    "@artalk/plugin-katex": "^0.1.8",
+    "@artalk/plugin-katex": "^0.1.9",
     "vue": "^3.4.26"
   }
 }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/ui/plugin-katex/package.json b/ui/plugin-katex/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@artalk/plugin-katex",
-  "version": "0.1.8",
+  "version": "0.1.9",
   "minAppVersion": "2.8.6",
   "license": "MIT",
   "description": "The katex plugin for artalk",
@@ -14,9 +14,7 @@
   "scripts": {
     "dev": "vite",
     "build": "vite build",
-    "serve": "vite preview",
-    "prepublish": "pnpm build",
-    "publish": "pnpm publish --access=public"
+    "serve": "vite preview"
   },
   "dependencies": {
     "artalk": "workspace:^",

diff --git a/ui/plugin-kit/package.json b/ui/plugin-kit/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@artalk/plugin-kit",
-  "version": "1.0.0",
+  "version": "1.0.3",
   "description": "The plugin kit for Artalk",
   "type": "module",
   "main": "dist/main.js",
@@ -27,10 +27,10 @@
   "license": "MIT",
   "dependencies": {
     "artalk": "workspace:^",
-    "picocolors": "^1.0.1"
+    "picocolors": "^1.0.1",
+    "@microsoft/api-extractor": "^7.46.1"
   },
   "devDependencies": {
-    "@microsoft/api-extractor": "^7.46.1",
     "esbuild-plugin-raw": "^0.1.8",
     "tsup": "^8.0.2"
   }

diff --git a/ui/plugin-kit/src/plugin/main.ts b/ui/plugin-kit/src/plugin/main.ts
@@ -128,6 +128,7 @@ export const ViteArtalkPluginKit = (opts: ViteArtalkPluginKitOptions = {}): Plug
         preserveSymlinks: false,
         noEmitOnError: undefined,
         target: ts.ScriptTarget.ESNext,
+        moduleResolution: ts.ModuleResolutionKind.Bundler,
         outDir: '.',
         declarationDir: '.',
       }
@@ -153,7 +154,7 @@ export const ViteArtalkPluginKit = (opts: ViteArtalkPluginKitOptions = {}): Plug
         return {
           code: `${code}
           // Mount plugin to browser window global
-          if (window) {
+          if (typeof window !== 'undefined') {
             !window.ArtalkPlugins && (window.ArtalkPlugins = {})
             window.ArtalkPlugins.${ctx.entryExportName} = ${ctx.entryExportName}
             window.Artalk?.use(${ctx.entryExportName})