Don't overwrite existing UDFs on local filesystem #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On startup the worker will download all UDF dylibs needed for the pipeline, then write them to a shared directory (/tmp/arroyo/local_udfs/{name}_{hash}.so) where it can be loaded. When using the process scheduler, this means that if two pipelines are using the same UDF, when the second one starts up it will overwrite the dylib that's already being used by the first.
For reasons that are not clear to me, it appears that certain UDFs can segfault when their shared library is replaced. This PR addresses that issue by not overwriting the UDF if it already exists (note that any changes to the UDF will give it a different hash, so it will still be written).