urlencode subject in confluent schema registry URLs (#759)

ArroyoSystems · Oct 21, 2024 · 54bccb1 · 54bccb1
1 parent a431d75
commit 54bccb1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/arroyo-rpc/Cargo.toml b/crates/arroyo-rpc/Cargo.toml
@@ -40,6 +40,7 @@ dirs = "5.0.1"
 arc-swap = "1.7.1"
 datafusion-common = { workspace = true }
 rand = "0.8.5"
+percent-encoding = "2.3.1"
 
 [build-dependencies]
 tonic-build = { workspace = true }

diff --git a/crates/arroyo-rpc/src/schema_resolver.rs b/crates/arroyo-rpc/src/schema_resolver.rs
@@ -8,6 +8,7 @@ use base64::write::EncoderWriter;
 use futures::future;
 use futures::stream::FuturesUnordered;
 use futures::StreamExt;
+use percent_encoding::{percent_encode, NON_ALPHANUMERIC};
 use reqwest::header::{HeaderMap, HeaderValue};
 use reqwest::{Client, StatusCode, Url};
 use serde::de::DeserializeOwned;
@@ -346,9 +347,10 @@ impl ConfluentSchemaRegistry {
     }
 
     fn subject_endpoint(&self, subject: &str) -> anyhow::Result<Url> {
+        let encoded_subject = percent_encode(subject.as_bytes(), NON_ALPHANUMERIC).to_string();
         self.client
             .endpoint
-            .join(&format!("subjects/{}/versions/", subject))
+            .join(&format!("subjects/{}/versions/", encoded_subject))
             .map_err(|e| {
                 anyhow!(
                     "'{}' is not a valid schema registry endpoint: {}",