Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routine editor #2439

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

routine editor #2439

wants to merge 14 commits into from

Conversation

ArnoldSmith86
Copy link
Owner

@ArnoldSmith86 ArnoldSmith86 commented Jan 11, 2025

An easy to use way to edit routines. Only a demo so far.

Changing count of a MOVE operation is implemented enough to show where this is going.

I will try to continue working on this steadily. Feel free to give early feedback but obviously I already have many ideas about how to continue this.


TODO list from meeting:

  • blocks
  • less details when uninteresting defaults
  • show "inplace collections" (collection: [ "id1", "id2" ]) that were already used in the routine
  • color coding (variables, collections, etc.)
  • verbose names for predefined stuff (player clicking button instead of ${playerName})
  • folding
  • for predefined variables/collections, show the description directly next to their buttons

PR-SERVER-BOT: You can play around with it here: https://test.virtualtabletop.io/PR-2439/pr-test (or any other room on that server)

@ArnoldSmith86 ArnoldSmith86 added enhancement New feature or request editor labels Jan 11, 2025
@96LawDawg
Copy link
Collaborator

What am I missing? I don't see anything different happening when I change the count?

"clickRoutine": [
    {
      "func": "MOVE",
      "from": "holder1",
      "to": "hand",
      "count": 1
    }
  ]

@ArnoldSmith86
Copy link
Owner Author

Properties panel. Only shows up if the widget has a clickRoutine.

@96LawDawg
Copy link
Collaborator

Nice start. Lots of potential. Things I've thought about before for this kind of UI:

  • Using MOVE as an example, changing "to" would be as easy as clicking on a widget in the room, selecting from a drop-down list of available holders, or typing in a name.
  • Collections that are available in that routine would also be available through a drop-down list.
  • Using SET as an example, when you add the "property" parameter, it would filter a list of the existing properties on that widget.

Just some random musings. You do what you think and what you can and you'll get feedback, and maybe even some help.

@ArnoldSmith86
Copy link
Owner Author

Oops. I didn't realize I broke the icons in the tooltips..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants