Fix crash when when SETting parent to self or descendant #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1414 for both routine operations and invalid typed entries in the JSON Editor. There is a quirk with the editor that I cannot figure out. Instead of getting red warning text, you get an alert pop-up with the warning. When the pop-up is closed, the invalid parent still shows up in the editor, but it has not been applied. I tried changing the jeGetContext function in jsonedit.js in the try block. But there were multiple problems with everything I tried. What is currently in this code is better than what we have and it works as is to prevent crashes and provide warning. But it could be improved.
96LawDawg
added
bug
No reason. Fixed. Tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1414 for both routine operations and invalid typed entries in the JSON Editor.
There is a quirk with the editor that I cannot figure out. Instead of getting red warning text, you get an alert pop-up with the warning. When the pop-up is closed, the invalid parent still shows up in the editor, but it has not been applied.
I tried changing the jeGetContext function in jsonedit.js in the try block. But there were multiple problems with everything I tried.
What is currently in this code is better than what we have and it works as is to prevent crashes and provide warning. But it could be improved.
PR-SERVER-BOT: You can play around with it here: https://test.virtualtabletop.io/PR-2412/pr-test (or any other room on that server)