Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time
get
is called, it evaluates the current value of the given property. For cards or wheninheritFrom
is involved, this can take a bit.This PR makes
get
remember the last value it determined and hopefully every possibility of changing that value, removes the cached value.Now I am very certain that this does not handle all the cases yet. But at least now my test case does not go in an endless loop anymore. The test case was switching the game to Color Whist in the Card Games game. Before this change, it took 2.77s on my laptop. Now it takes 1.19s.
Please help to find stuff that breaks these changes.
${PROPERTY x}
.