added JSON commands for picking a symbol #1936
Conversation
|
PR-SERVER-BOT: You can play around with it here: https://test.virtualtabletop.io/PR-1936/pr-test (or any other room on that server) After merging, a backup will be available at |
|
Kinda glitchy as the images are loading. Will it take a long time every time? PR1936.mp4 |
|
Quite a few VTT symbols are missing. For example, all of the arrows, the seats/chairs. But many other things also. |
|
It's probably missing the ones that are just copied from Material Icons. Do the glitches happen in production as well? What about the other PR? Which browser? |
Same problem there. |
|
Strange. I posted an answer to your other questions. They show up in Discord but not here. Will post again, just in case.
No. The icon picker for meta data has always worked fine.
Same problem.
Browsers with problem are Crome and Edge in Windows 11. No problem in Firefox. |
Is it still working in this PR? The only difference should be the size of the icons. I could show the small previews and only show bigger ones when filtered to <100. |
Yes, except for the flags. |
Those are also broken in production though, right? Windows doesn't have the flags iirc? I can probably make an exception for those and always display the images instead. |
Yes. They show up when you mouse over them, but otherwise just have the letters. |
|
How about now? |
|
Works in Chromium and Firefox on Windows 11. Does not work on iOS on newish iPad. |
There was a bit of discussion in Discord about this lately.
When working on the new editor, I included Noto Emoji for safe cross-platform display of emoji and all of the game-icons.net icons to the internal VTT assets. I also made a nice icon picker for them but so far it was only accessible from the game metadata.
This PR adds two JSON editor commands. One for image-based icons anywhere where the Upload Asset command was available. And one for buttons with class
symbolsormaterial-iconsfor thetextproperty.My plan is still to have new properties and card object types that make this even easier but this is a nice first easy step that makes these resources more freely available.
This is also still missing proper attribution. For now you will have to insert the proper attribution for game-icons.net icons into the game metadata manually.