Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added public library game Cheer Up! (similar to Skyjo) #1932

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

ArnoldSmith86
Copy link
Owner

Will probably do another 2 player playtest tomorrow.

@ArnoldSmith86
Copy link
Owner Author

PR-SERVER-BOT: You can play around with it here: https://test.virtualtabletop.io/PR-1932/pr-test (or any other room on that server)

After merging, a backup will be available at https://beta.virtualtabletop.io/editor/PR1932-pr-test.

@ArnoldSmith86 ArnoldSmith86 added enhancement New feature or request library Add new games, tutorials, or assets to public library labels Nov 10, 2023
@ArnoldSmith86
Copy link
Owner Author

Did some more tweaks after playtest. The main things that could be improved:

  1. At the start you flip two cards and the player with the highest cards begins. The highlighted seat doesn't reflect that.
  2. When a round ends, the player that ended it gets twice the penalty points if they don't have the lowest score. This could be automated but I just added a "double score of player X" option to the INPUT.
  3. When a round ends, the player that ended it begins the next round. The highlighted seat doesn't reflect that.

It's not really an issue if you know the game though. I might improve this at some point but probably not any time soon.

@96LawDawg
Copy link
Collaborator

I added a few lines of code to fix issue 3. I also added a few words to the instructions to clarify that the player that finishes/ends the round should press the play next button. That person then has the turn indicator.

I considered fixing issue 1 for you, but your seat and holder names were too random.

Copy link
Collaborator

@96LawDawg 96LawDawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved through test

@ArnoldSmith86
Copy link
Owner Author

I considered fixing issue 1 for you, but your seat and holder names were too random.

😆

@ArnoldSmith86 ArnoldSmith86 merged commit 85d7d3d into main Nov 14, 2023
@ArnoldSmith86 ArnoldSmith86 deleted the PL-addCheerUp branch November 14, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request library Add new games, tutorials, or assets to public library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants