Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flower Poker to PL #1929

Merged
merged 12 commits into from
Nov 11, 2023
Merged

Add Flower Poker to PL #1929

merged 12 commits into from
Nov 11, 2023

Conversation

96LawDawg
Copy link
Collaborator

Similar to Los Banditos (by Shobu).

Also fixes Pumpkin Curse that was recently added; it was missing the year in the meta data.

Similar to Los Banditos (from Shobu)

Also fixes recently added Pumpkin Curse that left off year in meta data.
@96LawDawg 96LawDawg added the library Add new games, tutorials, or assets to public library label Nov 8, 2023
@ArnoldSmith86
Copy link
Owner

PR-SERVER-BOT: You can play around with it here: https://test.virtualtabletop.io/PR-1929/pr-test (or any other room on that server)

After merging, a backup will be available at https://beta.virtualtabletop.io/editor/PR1929-pr-test.

@ArnoldSmith86
Copy link
Owner

At least the library images are links to Midjourney.

@96LawDawg
Copy link
Collaborator Author

Good catch. There's one more I need to fix. Is there an easy way to check that other than searching for "http" in the JSON?

@ArnoldSmith86
Copy link
Owner

ArnoldSmith86 commented Nov 9, 2023

The assets sidebar should show them but I didn't think of a good way to include metadata assets yet:

image

Using grep, you can check all games at once but that also matches actual links in the metadata (bgg etc): grep http library/*/*/*json

@96LawDawg
Copy link
Collaborator Author

Maybe I don't know how to use that Assets sidebar thing properly. For me, it just is a file interface: download or upload. It doesn't display anything.

@ArnoldSmith86
Copy link
Owner

Then it didn't find any links.

Copy link
Owner

@ArnoldSmith86 ArnoldSmith86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@ArnoldSmith86 ArnoldSmith86 enabled auto-merge (squash) November 11, 2023 16:37
@ArnoldSmith86 ArnoldSmith86 merged commit 81b8879 into main Nov 11, 2023
6 checks passed
@ArnoldSmith86 ArnoldSmith86 deleted the PL-add-FlowerPoker branch November 11, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library Add new games, tutorials, or assets to public library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants