Remove num-bigint
as a crate dependency
#6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
num-bigint
as a direct create dependency. I'm still keeping it in dev deps because I need it to parse decimal strings. Other than that we're using Arkwork'sBigint
entirely!This PR also up-levels
SecretKey
: it's no longer an arbitraryBigInt
, it's now a proper field element (Fr
). This means we automatically enforce that it's between 0 and p-1.It took a bit of work to find
from_be_bytes_mod_order
; glad it exists.