Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(smolagents): update internal smolagents import for compatibility with versions post 1.5.0 #1229

Merged
merged 3 commits into from
Jan 23, 2025
Merged

fix(smolagents): update internal smolagents import for compatibility with versions post 1.5.0 #1229

merged 3 commits into from
Jan 23, 2025

Conversation

clefourrier
Copy link
Contributor

@clefourrier clefourrier requested a review from a team as a code owner January 23, 2025 10:04
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@clefourrier clefourrier changed the title Update _wrappers.py to fit new file organisation in smolagents lib Update smolagent import in _wrappers.py to fit new file organisation in versions post 1.5.0 Jan 23, 2025
@clefourrier
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@clefourrier
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Jan 23, 2025
@github-actions
@clefourrier has signed the CLA in #1229
650f01d
@clefourrier clefourrier mentioned this pull request Jan 23, 2025
Closed
@aymeric-roucher
Copy link
Contributor

Thank you @clefourrier ! +1 on merging this!

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 23, 2025
@axiomofjoy axiomofjoy changed the title Update smolagent import in _wrappers.py to fit new file organisation in versions post 1.5.0 fix(smolagents): update internal smolagents import for compatibility with versions post 1.5.0 Jan 23, 2025
@axiomofjoy
Copy link
Contributor

Thanks so much @clefourrier! I switched to check the version with if else to avoid the overhead of catching an exception.

@axiomofjoy axiomofjoy merged commit b338113 into Arize-ai:main Jan 23, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Merged
@axiomofjoy
Copy link
Contributor

This change is released in openinference-instrumentation-smolagents 0.1.1

@clefourrier
Copy link
Contributor Author

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axiomofjoy axiomofjoy axiomofjoy approved these changes

Assignees
No one assigned
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clefourrier @aymeric-roucher @axiomofjoy