FlightData: allow plugin tab visibility to persist #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This call to saveTabControlActions in unnecessary, and tabs added by plugins won't exist yet when this gets called the first time, so they get cleared from the settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition of
saveTabControlActionshere means that users cannot save their visibility preferences for the plugin-added tabs. Plugin tabs don't exist when this first gets called, so their visibility settings get wiped out on startup.Currently, plugins have to do one of the following:
tabcontrolactionssetting and save a backup of the user's preference to restore later.Removing this line should have no negative impacts.