Fix IsRelatedToActivePlayer logic for itemlink groups #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this has been discussed already what the issue is, in short IsSharingGroupWith tells you if you have an itemlink in common with a real player rather than telling you if a given player is either you or an itemlink. So, this makes the following changes:
IPlayerHelper.ActivePlayer
. Since we do plenty of comparisons with active player I felt it was useful to have. Also outside of this implementation, there were a few times I wanted it for my own usage in HK.Player.GetGroupMembers(playerHelper).Contains(playerHelper.ActivePlayer)
or similar (which now works because of value equality on PlayerInfo)