add pause all / unpause all action contracts #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahgwai
reviewed
Oct 25, 2023
| } | ||
|
|
||
| function getSequencers() public view returns (address[] memory) { | ||
| return sequencers; |
There was a problem hiding this comment.
i think sequencers can be expected to change, likewise outboxes, so we probably dont want to hardcode them here. I think it would be better to add some pause functionality to the bridge instead, but maybe that's a longer term solution for a different pr?
There was a problem hiding this comment.
hmm yeah agreed; pausable bridge let's us more directly both pause sequencing, outbox execution, and gives means to pause force inclusion, v nice. Kinda like the idea of pushing forward with that in the short/ASAP - term. (tho in the immediate term maybe we temporarily have this? idk)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including adding all active outboxes and batch posters to the L1AddressRegistry to make life easier. Means registry has to be redeployed if either is modified; could add a health check to ensure we don't forget.