orbit chain governance deployment contracts #216
+330
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvladika
reviewed
Oct 16, 2023
src/orbit-chain-governance/factories/GovernanceChainGovFactory.sol
Outdated
Show resolved
Hide resolved
src/orbit-chain-governance/factories/GovernanceChainGovFactory.sol
Outdated
Show resolved
Hide resolved
src/orbit-chain-governance/factories/GovernanceChainGovFactory.sol
Outdated
Show resolved
Hide resolved
godzillaba
reviewed
Oct 16, 2023
src/orbit-chain-governance/factories/GovernanceChainGovFactory.sol
Outdated
Show resolved
Hide resolved
src/orbit-chain-governance/factories/GovernanceChainGovFactory.sol
Outdated
Show resolved
Hide resolved
| timelockLogic = address(new ArbitrumTimelock()); | ||
| } | ||
|
|
||
| function deployStep1(DeployParams memory params) |
There was a problem hiding this comment.
what if we did all of this in the constructor? (same w/ deploySetp2)
yahgwai
approved these changes
Dec 13, 2023
| /// that implements IVotesUpgradeable to already be deployed on the governance chain. | ||
| /// To be executed prior to ParentChainGovFactory on the parent chain. | ||
|
|
||
| contract GovernanceChainGovFactory is Ownable { |
There was a problem hiding this comment.
Can we add a test that deploys both of these contracts? Maybe we can run a modified verifier script against them too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.