Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: Eli J. Donahue <[email protected]>
  • Loading branch information
sampoearas and EliJDonahue authored Jul 25, 2019
1 parent 20d949b commit 18955e7
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions Innovator/Client/scripts/kanban/js/script.js
Original file line number Diff line number Diff line change
Expand Up @@ -240,13 +240,11 @@ function loadBoards() {
try {
fileUrl = inn.getFileUrl(vaultref.split("?fileId=")[1], 1);
vaultRefTable[vaultref] = fileUrl;
}
catch(err){
} catch(err) {
console.log("Profile Image for " + item.getPropertyAttribute("created_by_id", "keyed_name") + " is malformed. Please choose a different image.");
}

}
else {
} else {
vaultRefTable[vaultref] = fileUrl;
}

Expand Down Expand Up @@ -464,16 +462,14 @@ function loadSingleBoard(boardId, reload) {
var vaultref = item.getProperty("managerpicture");
var fileUrl = "../kanban/nomanager.png";
if ((vaultref !== undefined) && (vaultRefTable[vaultref] == undefined)) {
try{
try {
fileUrl = inn.getFileUrl(vaultref.split("?fileId=")[1], 1);
vaultRefTable[vaultref] = fileUrl;
}
catch(err){
} catch (err) {
console.log("Profile Image for " + item.getPropertyAttribute("manager", "keyed_name") + " is malformed. Please choose a different image.");
}

}
else {
} else {
vaultRefTable[vaultref] = fileUrl;
}

Expand Down

0 comments on commit 18955e7

Please sign in to comment.