Improve controller textures #8158
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Columns of controllers now have a matching color. This is achieved by alternating a and b variants of the controllers, similar to what was already done for the inside variants.
This extends the color matching of the columns to the blocks (i.e. the corner pieces) as well. It only works for faces on the same plane. Colors on the edge of the block will still not match as it is mathematically impossible.
This extends the color matching to the inside variants of controller blocks. For those there were also minor bugs in the texture that were corrected as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Discord, here are some ideas on how to improve the controller textures to avoid color mismatches in certain places. The basic idea is to expand on the (currently broken) feature for the 'inside' variant of controllers to have a and b variants of the blocks with different textures (colors swapped). It has been separated into 3 commits, each dealing with one variant of controller blocks (columns, blocks (i.e. corners) and inside).
I'm unfamiliar with what these changes will cause in terms of trouble for upgrading/downgrading existing worlds since the block states change. If columns and corners both will be merged some thought should be given to the question whether there should be a refactoring (moving the a or b information into a separate block state, as all CONTROLLER_TYPE will have a and b subtypes).
Another problem could be 3rd party texture packs that could break or require adaptations. Is that something we need to consider?
Some example pictures:
Note that this approach cannot solve certain color mismatches, in particular corner edges and inner edges:
I'm posting this as a draft pull request as there should probably be some discussion.