Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use jump to when cursor not rendered #1015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

richardshiue
Copy link
Contributor

@richardshiue richardshiue commented Jan 10, 2025

cases to consider that I don't know the best solution to:

  • whether to replace existing logic with the new one and not check for the cursor rect
  • when using shrinkWrap, the ItemScrollableController isn't available

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.00%. Comparing base (c68e5f6) to head (b8ad378).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ditor_component/service/scroll_service_widget.dart 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
- Coverage   72.16%   72.00%   -0.17%     
==========================================
  Files         319      319              
  Lines       15246    15339      +93     
==========================================
+ Hits        11003    11045      +42     
- Misses       4243     4294      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant