fix: using space bar to move the cursor not working on Android #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 319 319
Lines 15324 15323 -1
=======================================
Hits 11031 11031
+ Misses 4293 4292 -1 ☔ View full report in Codecov by Sentry. |
LucasXu0
pushed a commit
to LucasXu0/appflowy-editor
that referenced
this pull request
Jan 7, 2025
LucasXu0
pushed a commit
to LucasXu0/appflowy-editor
that referenced
this pull request
Jan 7, 2025
LucasXu0
pushed a commit
to LucasXu0/appflowy-editor
that referenced
this pull request
Jan 7, 2025
LucasXu0
pushed a commit
to LucasXu0/appflowy-editor
that referenced
this pull request
Jan 7, 2025
LucasXu0
added a commit
that referenced
this pull request
Jan 7, 2025
* fix: unable to parse image if the image is inside the paragraph * test: unable to parse image if the image is inside the paragraph * fix: using space bar to move the cursor not working on Android (#1013) --------- Co-authored-by: Morn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
selection != editorState.selectionwill always befalseremove it then the space bar is able to work correctly