-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set demand control percentage #185
base: master
Are you sure you want to change the base?
Conversation
G'day, I desperately need this function by the start of the heating season, as Daikin changed the cloud API and removed the option to set demand control. @Apollon77 , what's missing here and @Matze2 do you find the time to add what's needed in order to release the feature? thanks a lot :-)!! |
Hi @indie89 , there were some comments from @Apollon77 in the corresponding PR of the low-level project (Apollon77/daikin-controller#268). I remember that I already worked on them but couldn't test anything during summer. There should be some progress in the next weeks.... |
Hi @Matze2 , |
17e88dc
to
c3a252b
Compare
Hi @indie89, today I worked on the feedback of @Apollon77 for the "reading" part. |
The last commit 57ad37b is optional. It changes the info log from
to
This helped me to check if demand control is supported (demandControl field is shown) and if values get updated (demandControl > 0). |
It might not be supported.
This might not be the final solution.
On top, it implicitly indicates if demandControl is supported or not.
57ad37b
to
28ba916
Compare
No, all good. thank you ... will check and merge likely tomorrow/after library got updated |
No worries. Appreciate your effort. 👍 |
This PR is on top of #184.
It also depends on PRs Apollon77/daikin-controller#268 and Apollon77/daikin-controller#269.
For now only change of demand control percentage is supported.
This PR contains one part under discussion because the new writable parameter "maxPower" does not belong to group "control" but to "demandControl". Since all writable parameter names itself are unique it is enough to check with the second namespace and strip it off. The rest of the logic stays the same.
With this PR I could replace the usage of "daikin-cloud.0..climateControl.demandControl.modes.fixed" in my scripts.