Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set demand control percentage #185

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Matze2
Copy link

@Matze2 Matze2 commented Mar 16, 2024

This PR is on top of #184.

It also depends on PRs Apollon77/daikin-controller#268 and Apollon77/daikin-controller#269.

For now only change of demand control percentage is supported.

This PR contains one part under discussion because the new writable parameter "maxPower" does not belong to group "control" but to "demandControl". Since all writable parameter names itself are unique it is enough to check with the second namespace and strip it off. The rest of the logic stays the same.

With this PR I could replace the usage of "daikin-cloud.0..climateControl.demandControl.modes.fixed" in my scripts.

@indie89
Copy link

indie89 commented Sep 9, 2024

G'day, I desperately need this function by the start of the heating season, as Daikin changed the cloud API and removed the option to set demand control. @Apollon77 , what's missing here and @Matze2 do you find the time to add what's needed in order to release the feature? thanks a lot :-)!!

@Matze2
Copy link
Author

Matze2 commented Sep 15, 2024

Hi @indie89 ,

there were some comments from @Apollon77 in the corresponding PR of the low-level project (Apollon77/daikin-controller#268).

I remember that I already worked on them but couldn't test anything during summer.

There should be some progress in the next weeks....

@indie89
Copy link

indie89 commented Sep 16, 2024

Hi @Matze2 ,
thanks for your reply!
As a temporary workaround I implemented the http api call in my blockly script so that I at least can set the demand control percentage according to the outside temperature. So until this PR ist accepted I still have a working power control.
Thanks in advance an have a good week!

@Matze2 Matze2 force-pushed the set-demand-control branch 2 times, most recently from 17e88dc to c3a252b Compare September 29, 2024 12:45
@Matze2
Copy link
Author

Matze2 commented Sep 29, 2024

Hi @indie89, today I worked on the feedback of @Apollon77 for the "reading" part.
The "reading" is more sensitive since it might break existing adapters that do not have demand control support integrated.
So I hope we make here some steps forward.

@Matze2
Copy link
Author

Matze2 commented Oct 5, 2024

The last commit 57ad37b is optional. It changes the info log from

85 Values updated

to

85 Values updated: {"deviceInfo":24,"modelInfo":7,"control":9,"controlInfo":36,"sensorInfo":5,"demandControl":4}

This helped me to check if demand control is supported (demandControl field is shown) and if values get updated (demandControl > 0).
If you don't like it I can remove it from PR.

@Apollon77
Copy link
Owner

Apollon77 commented Oct 6, 2024

No, all good. thank you ... will check and merge likely tomorrow/after library got updated

@Matze2
Copy link
Author

Matze2 commented Oct 6, 2024

No worries. Appreciate your effort. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants