Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds attributes back to __init__ #36

Merged
merged 5 commits into from
Nov 20, 2024
Merged

fix: adds attributes back to __init__ #36

merged 5 commits into from
Nov 20, 2024

Conversation

bitwise-constructs
Copy link
Contributor

What I did

NETWORKS, Optimism, and OptimismConfig attributes were accidentally removed with perf improvements and this adds them back in

fixes: #

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

antazoey
antazoey approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prolly rm Any return and then guchi

@bitwise-constructs bitwise-constructs enabled auto-merge (squash) November 20, 2024 01:17
@antazoey antazoey disabled auto-merge November 20, 2024 01:19
@antazoey antazoey merged commit a5be01e into ApeWorX:main Nov 20, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antazoey antazoey antazoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitwise-constructs @antazoey