Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #687 #688

Closed
wants to merge 1 commit into from
Closed

Issue #687 #688

wants to merge 1 commit into from

Conversation

Ravi-1606
Copy link

@Ravi-1606 Ravi-1606 commented Oct 21, 2024

Description

This PR addresses the issue #687 where images were lacking proper padding and spacing, making them appear cluttered. Additionally, the border-radius of the images was being removed upon hover, causing an inconsistent appearance. The changes implemented ensure that:

  1. Each image has adequate padding for a clean and spaced layout.
  2. Proper spacing is added between images to enhance visual clarity.
  3. The border-radius remains intact on hover for a consistent, smooth, and rounded appearance.

These improvements lead to a more polished and user-friendly image display in the project.

Related Issues

  • Closes #687

Type of PR

  • Bug Fix

Screenshots / videos (if applicable)

video_2024-10-21_22-28-24.mp4

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR.
  • I have performed a self-review of my code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

The fix improves the overall image layout by maintaining visual consistency with the border-radius and ensuring proper spacing between images. This leads to a more aesthetically pleasing and user-friendly interface.

…r-radius remains intact on hover for a consistent rounded appearance.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Ravi-1606! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 83ff900
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/671688644376c60008ff3fa6
😎 Deploy Preview https://deploy-preview-688--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ravi-1606 Ravi-1606 deleted the Ravi branch October 22, 2024 06:47
@Ravi-1606
Copy link
Author

Can you tell me why you closed this branch without merging? Actually, I am new to GitHub and open source contribution so want to know where I am going wrong @Anjaliavv51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants