-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer adjusted with small device responsiveness in cart , about ,services ,collection section #482
Conversation
…lection , services , index section
✅ Deploy Preview for rococo-mooncake-0d89f7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Abbas7120! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
@Abbas7120 resolve merge conflicts. |
Done! |
@Abbas7120 menu and service page code is load diff |
But my task is to made footer section same in all sections so I do it |
and it is made |
u didn't made it responsive as ur dimensions are in appropriate , ur changes r not applied. |
but my main task is to made all section footer same that i do |
mention the related issue number in PR description. |
then y did u mention footer adjusted with small screens name as for the PR. |
no issue , overlap of footer in menu.html page |
@Abbas7120 no issue , for footer also add all these social icons. |
@Abbas7120 more over update ur branch. |
Made footer UI same in each section label it gssoc - extd level (2/3) hacktoberfest-accepted
#466 Issue made by me and resolved