Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer adjusted with small device responsiveness in cart , about ,services ,collection section #482

Closed
wants to merge 4 commits into from

Conversation

Abbas7120
Copy link

@Abbas7120 Abbas7120 commented Oct 13, 2024

Made footer UI same in each section label it gssoc - extd level (2/3) hacktoberfest-accepted
image
image

#466 Issue made by me and resolved

Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 692b49a
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/670bd2d4e57a2e0008c4c415
😎 Deploy Preview https://deploy-preview-482--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Abbas7120! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Anjaliavv51
Copy link
Owner

@Abbas7120 resolve merge conflicts.

@Abbas7120
Copy link
Author

Done!

@Anjaliavv51
Copy link
Owner

@Abbas7120 menu and service page code is load diff

image

@Anjaliavv51
Copy link
Owner

Done!

it is not made responsive , make it responsive according to the dimensions , see the below image u can click on them and u can get the dimensions

image

@Abbas7120
Copy link
Author

Abbas7120 commented Oct 13, 2024

But my task is to made footer section same in all sections so I do it

@Abbas7120
Copy link
Author

and it is made

@Anjaliavv51
Copy link
Owner

and it is made

u didn't made it responsive as ur dimensions are in appropriate , ur changes r not applied.
to get perfect dimensions , u need to explore that.

@Abbas7120
Copy link
Author

but my main task is to made all section footer same that i do

@Anjaliavv51
Copy link
Owner

but my main task is to made all section footer same that i do

mention the related issue number in PR description.

@Abbas7120
Copy link
Author

#466

@Anjaliavv51
Copy link
Owner

Anjaliavv51 commented Oct 13, 2024

#466

then y did u mention footer adjusted with small screens name as for the PR.

@Anjaliavv51
Copy link
Owner

#466

no issue , overlap of footer in menu.html page

image

@Abbas7120
Copy link
Author

Mam as on my PC in some small devices Dimension its looking good this so that why I added with this commit
image

@Anjaliavv51
Copy link
Owner

@Abbas7120 no issue , for footer also add all these social icons.

image

@Anjaliavv51
Copy link
Owner

@Abbas7120 more over update ur branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants