Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨[feature Request]: Hover on question of FAQ will display answer #472

Merged
merged 4 commits into from
Oct 13, 2024
Merged

✨[feature Request]: Hover on question of FAQ will display answer #472

merged 4 commits into from
Oct 13, 2024

Conversation

jvkousthub
Copy link
Contributor

Description

Added hover effect to faq section where upon hover the answer will be displayed

Related Issues

Type of PR

  • (Feature Addition)

Screenshots / videos (if applicable)

Screen.Recording.2024-10-13.134333.mp4

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

github-actions[bot]
github-actions bot reviewed Oct 13, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @jvkousthub! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@netlify Netlify
Copy link

netlify bot commented Oct 13, 2024 •
edited
Loading

✅ Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit d17b2a0
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/670b8f4cf453b100092d4970
😎 Deploy Preview https://deploy-preview-472--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Anjaliavv51
Copy link
Owner

Description

Added hover effect to faq section where upon hover the answer will be displayed

Related Issues

Type of PR

  • (Feature Addition)

Screenshots / videos (if applicable)

Screen.Recording.2024-10-13.134333.mp4

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

this change is not good , coz arrows should be also displayed.

@jvkousthub
Copy link
Contributor Author

jvkousthub commented Oct 13, 2024 •
edited
Loading

Description

Added hover effect to faq section where upon hover the answer will be displayed

Related Issues

Type of PR

  • (Feature Addition)

Screenshots / videos (if applicable)

Screen.Recording.2024-10-13.134333.mp4

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

this change is not good , coz arrows should be also displayed.
@Anjaliavv51
please tell if any more changes are required ill edit the code

@jvkousthub
Copy link
Contributor Author

Screen.Recording.2024-10-13.141052.mp4

will it be fine??? @Anjaliavv51

@Anjaliavv51
Copy link
Owner

@jvkousthub it should have arrow pointing down when it is closed and arrow pointing up when opened.

@jvkousthub
Copy link
Contributor Author

@jvkousthub it should have arrow pointing down when it is closed and arrow pointing up when opened.

ok

@jvkousthub
Copy link
Contributor Author

Screen.Recording.2024-10-13.142833.mp4

@Anjaliavv51 Ok??

@Anjaliavv51
Copy link
Owner

@jvkousthub add heading also increase the width like below.

image

@jvkousthub
Copy link
Contributor Author

Screen.Recording.2024-10-13.144137.mp4

done @Anjaliavv51

@jvkousthub
Copy link
Contributor Author

@Anjaliavv51 add level label

@Anjaliavv51 Anjaliavv51 merged commit 813c1d3 into Anjaliavv51:main Oct 13, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@jvkousthub jvkousthub

Labels
enhancement New feature or request good first issue Good for newcomers gssoc-ext hacktoberfest-accepted Level 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨[feature Request]: Hover on question of FAQ will display answer
2 participants
@jvkousthub @Anjaliavv51