Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[feature Request]:Dark Mode/ Light Mode Toggle #229

Closed
wants to merge 7 commits into from

Conversation

Poushmita
Copy link

Description

This PR adds a Dark mode/Light mode toggle feature to the website, allowing users to switch between the two modes. The feature includes style adjustments for both modes to ensure consistent visual quality in both themes.

Related Issues

Changes Made

  • Implemented Dark mode/Light mode toggle functionality using JavaScript.
  • Added new CSS styles for Dark mode.
  • Updated the existing Light mode styles to ensure compatibility with the toggle functionality.
  • Added an icon/button for toggling modes that is visible on all pages.

Screenshots / videos (if applicable)

Home Page:

Light Mode:
Screenshot 2024-10-05 163543
Screenshot 2024-10-05 165017

Dark Mode:
Screenshot 2024-10-05 163657
Screenshot 2024-10-05 164019

About Page:

Light Mode:
Screenshot 2024-10-05 164131
Screenshot 2024-10-05 164833

Dark Mode:
Screenshot 2024-10-05 164219
Screenshot 2024-10-05 164345

Services Page:

Light Mode:
Screenshot 2024-10-05 164432
Screenshot 2024-10-05 164728

Dark Mode:
Screenshot 2024-10-05 164509
Screenshot 2024-10-05 164600
Screenshot 2024-10-05 164646

Contact Page:

Light Mode:
Screenshot 2024-10-05 165109
Screenshot 2024-10-05 165137

Dark Mode:
Screenshot 2024-10-05 165215
Screenshot 2024-10-05 165821

Cart Page:

Light Mode:
Screenshot 2024-10-05 165926
Screenshot 2024-10-05 165954

Dark Mode:
Screenshot 2024-10-05 170434
Screenshot 2024-10-05 170505

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Poushmita! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit 402070b
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/6702438f062ef500085e8580
😎 Deploy Preview https://deploy-preview-229--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Poushmita
Copy link
Author

@Anjaliavv51 Please check out my PR and let me know if any changes are needed.

@Anjaliavv51
Copy link
Owner

Look at the below pic , navbar is not updated.

image

@Anjaliavv51
Copy link
Owner

@Poushmita update the branch and also resolve the conflicts.

@Poushmita
Copy link
Author

@Anjaliavv51 Changed the code for navbar and resolved the conflict. Please let me know if anything is needed.

Updated

image

@Anjaliavv51
Copy link
Owner

@Poushmita resolve conflicts and also place the dark mode button , where i have marked in the below image it should float in the webpage.

WhatsApp Image 2024-10-08 at 15 34 13_dd8c9e8e

@Anjaliavv51
Copy link
Owner

@Poushmita this pr has to be made so many changes , and their are overlap with ur code , so i am closing the PR , and try to create another PR with perfect changes , u can ur changes in link below deploy link.

https://deploy-preview-229--rococo-mooncake-0d89f7.netlify.app/html-files/services

@Poushmita
Copy link
Author

@Anjaliavv51 I think this conflict is occurring again and again due to the same branch. Please give me sometime, I am implementing the changes in a new branch and opening a PR request.

2004shweta pushed a commit to 2004shweta/Retro that referenced this pull request Oct 15, 2024
enhanced available cities section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[feature Request]: Dark Mode/ Light Mode Toggle
2 participants