Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New endpoints for Microsoft & DeepL | MyMemory language detecting fixes | Minor fixes #95

Merged
merged 7 commits into from
Sep 5, 2023
Merged

Conversation

ZhymabekRoman
Copy link
Contributor

@ZhymabekRoman ZhymabekRoman commented Aug 29, 2023

Closes #28, #81, #65, #75

@ZhymabekRoman ZhymabekRoman changed the title New endpoints for Microsoft New endpoints for Microsoft & DeepL Aug 29, 2023
@ZhymabekRoman ZhymabekRoman marked this pull request as draft August 29, 2023 14:00
@ZhymabekRoman ZhymabekRoman marked this pull request as ready for review September 4, 2023 10:19
@ZhymabekRoman ZhymabekRoman marked this pull request as draft September 4, 2023 10:37
@ZhymabekRoman ZhymabekRoman marked this pull request as ready for review September 4, 2023 10:50
@ZhymabekRoman
Copy link
Contributor Author

@Animenosekai, this PR also ready. I made some huge architectural changes, let me know if there is a problem or something like that.

@ZhymabekRoman
Copy link
Contributor Author

I found caching problem, if we specify custom keyword argument like in DeepL translate function fromality="formal", and we change to fromality="informal", translatepy responses from cache

@ZhymabekRoman ZhymabekRoman changed the title New endpoints for Microsoft & DeepL New endpoints for Microsoft & DeepL | MyMemory language detecting fixes | Minor fixes Sep 4, 2023
@Animenosekai
Copy link
Owner

Before merging, could you change the name of the base_agregator.py file to base_aggregator.py

@ZhymabekRoman
Copy link
Contributor Author

Yep, I'm sorry for this mistake

@Animenosekai Animenosekai merged commit 4a8f6a2 into Animenosekai:next Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants