Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#80] Prep for fixing auth token bug #82

Merged
merged 16 commits into from
Mar 21, 2024
Merged

[#80] Prep for fixing auth token bug #82

merged 16 commits into from
Mar 21, 2024

Conversation

delano
Copy link
Contributor

@delano delano commented Mar 21, 2024 •
edited by van bot
Loading

User description

Prep for issue #80.

Type

enhancement, other

Description

  • Added @trunkio/launcher dependency to package-lock.json for the API.
  • Disabled strict peer dependencies in .npmrc for UI.
  • Updated several dependencies including @nuxt/fonts, date-fns, and next-auth in package.json for UI.
  • Added @vueform/builder-nuxt, @vueform/nuxt, @vueform/vueform, and prettier dependencies to package.json for UI.
  • Added and updated numerous dependencies in pnpm-lock.yaml for UI.
  • Configured Tailwind CSS for @vueform in tailwind.config.ts for UI.
  • Added vueform.config.ts for @vueform configuration in UI.

Changes walkthrough

Relevant files
Dependencies
package-lock.json
Add `@trunkio/launcher` dependency to `package-lock.json`

apps/api/package-lock.json

  • Added @trunkio/launcher dependency
 +24/-0   
package.json
Update dependencies and add @vueform and prettier to package.json

apps/ui/package.json

  • Updated several dependencies including @nuxt/fonts, date-fns, and
    next-auth
  • Added @vueform/builder-nuxt, @vueform/nuxt, @vueform/vueform, and
    prettier dependencies
  • Added prettier script
    		•  +15/-11 
    pnpm-lock.yaml
    Update and add dependencies in `pnpm-lock.yaml`                   

    apps/ui/pnpm-lock.yaml

  • Added and updated numerous dependencies including @img/sharp,
    @vueform, and color
    		•  +346/-168
    Configuration changes
    .npmrc
    Disable strict peer dependencies in `.npmrc`                         

    apps/ui/.npmrc

    • Changed strict-peer-dependencies to false
    		 +1/-1     
    tailwind.config.ts
    Configure Tailwind CSS for `@vueform` in `tailwind.config.ts`

    apps/ui/tailwind.config.ts

  • Added content configuration for Tailwind CSS
  • Added @vueform/vueform and @vueform/builder plugins
    		•  +14/-0   
    vueform.config.ts
    Add `vueform.config.ts` for `@vueform` configuration         

    apps/ui/vueform.config.ts

    • Added vueform.config.ts for @vueform configuration
    		 +17/-0   

    delano added 15 commits March 13, 2024 22:18
    @delano
    [#80] Added vueform and vueform builder deps
    519622a 
    Includes updated peer dependencies as needed for the new deps.
    @delano
    [#80] Add request form
    8387f31 
    - Import Vueform library and components
- Define dashboard page layout and meta
- Configure form steps, fields, rules and default values
- Cover accommodation details, location, rooms, facilities, etc.
- Add sections for host info, gallery, pricing and availability
- Include terms and complete page to finish listing creation flow
    @delano
    [#80] Add vueform builder config
    2f8ffcb 
    - Add vueform.config.js for registering locales, theme and plugins
- Register English locale
- Register Tailwind theme
- Register @vueform/builder plugin
- Add Tailwind content config in tailwind.config.js
- Install and configure Prettier formatter
    @delano
    [#80] Add migration for altering profile address and address_verbatim…
    28e1287 
    … fields
    @delano
    [#80] Add prettier configuration file
    e9c640e
    @delano
    [#80] Add Trunk package-lock.json with dependencies
    b7a907c
    @delano
    [#80] Add builder page with form loading logic
    1d27dce
    @delano
    [#80] Removed Vueform Builder
    72657b1
    @delano
    [#80] Merge branch 'main' into delano/80-auth-token-bug
    fb697ab
    @delano
    [#80] Add @iconify-json/streamline
    8ccdba0
    @delano
    [#80] Update header links
    3f4d49a
    @delano
    [#80] Add Vueform Builder UI test page
    39166eb 
    - Import Vueform Builder plugin
- Add Builder page
- Configure Tailwind CSS for Builder styles
- Update Vueform config for Builder plugin
    @delano
    [#80] Refactored request form routes and components
    94f214e 
    * Moved request form component to reuse at `/requests/new`
* Updated nav links to open requests subtree by default
* Added request history and new request pages to requests nav

The request form component was extracted out of the old `/requestform` route so it can be reused at the new `/requests/new` location instead. The dashboard nav tree for requests was also updated to default to open when on any `/requests` path and nested routes were added for the request history and new request pages. Lastly the header navlink to the form was redirected from `/requestform` to `/requests/new` as well.
    @delano
    [#80] Standardized formatting & now using local assets
    adf192d 
    The code changes replace the placeholder user profile images in the request sample data with a consistent local placeholder image. Additionally, the sample data and various strings are reformatted to use consistent double quotes and whitespace style.

This standardizes the sample data formatting to follow project conventions, removes external image references, and improves placeholder visual consistency. The changes help prepare the sample data for integration in additional views across the application.
    @delano
    [#80] Delete clients.vue file and related code
    7a3fbeb
    @delano delano requested review from joshuakeaton and van March 21, 2024 00:10
    @van van bot added the enhancement label Mar 21, 2024
    @van van
    Copy link

    van bot commented Mar 21, 2024

    PR Description updated to latest commit (7a3fbeb)

    1 similar comment
    @van van
    Copy link

    van bot commented Mar 21, 2024

    PR Description updated to latest commit (7a3fbeb)

    @delano delano self-assigned this Mar 21, 2024
    @van van bot added the other label Mar 21, 2024
    @van van
    Copy link

    van bot commented Mar 21, 2024

    PR Description updated to latest commit (7a3fbeb)

    @joshua-keaton Joshua Keaton
    Copy link

    joshua-keaton bot commented Mar 21, 2024

    PR Review

    ⏱️ Estimated effort to review [1-5]

    3, because the PR introduces a significant number of dependency updates and configuration changes across multiple files and platforms. The changes affect both the backend and frontend parts of the application, including updates to major libraries and the addition of new dependencies. Reviewing these changes requires a thorough understanding of the project's architecture and the potential impact of each update on the application's functionality and performance.

    🧪 Relevant tests

    No

    🔍 Possible issues

    Possible Issue: The addition of new dependencies and updates to existing ones could introduce breaking changes or compatibility issues with the current codebase. It's essential to ensure that all updated dependencies are compatible with the project's existing code and that the new dependencies are necessary and do not introduce security vulnerabilities.

    Possible Performance Concern: The introduction of new libraries and updates to existing ones could potentially impact the application's performance. It's important to assess the performance implications of these changes and ensure that they do not negatively affect the user experience.

    🔒 Security concerns

    No

    joshua-keaton[bot]
    joshua-keaton bot reviewed Mar 21, 2024
    View reviewed changes
    apps/api/package-lock.json Show resolved Hide resolved
    apps/ui/package.json Show resolved Hide resolved
    apps/ui/nuxt.config.ts Show resolved Hide resolved
    apps/ui/tailwind.config.ts Show resolved Hide resolved
    @delano delano marked this pull request as ready for review March 21, 2024 00:39
    @delano
    [#80] Add test infrastructure and dependencies
    48546f8 
    - Install Vitest, Testing Library, Playwright, and Happy DOM
- Add Jest and Testing Library types
- Configure Vite test environment
- Add sample Vitest config file
- Update dependencies in package.json and lock files
    @delano delano merged commit cc4178d into main Mar 21, 2024
    0 of 2 checks passed
    @delano delano deleted the delano/80-auth-token-bug-prep branch March 21, 2024 03:01
    @delano delano mentioned this pull request Mar 25, 2024
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @joshua-keaton joshua-keaton[bot] joshua-keaton[bot] left review comments

    @joshuakeaton joshuakeaton Awaiting requested review from joshuakeaton

    @van van Awaiting requested review from van

    Assignees

    @delano delano

    Labels
    enhancement other Review effort [1-5]: 3
    Projects
    AFB Requests MVP - June 2024
    Status: ✔️ Done
    Milestone
    Early testing (with friendlies)
    Development

    Successfully merging this pull request may close these issues.
    1 participant
    @delano