Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delete dependabot.yml and migrate to version catalogues with dependency version bumps #134

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 4 additions & 34 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Bug Report
about: Report any issues regarding the project and help us identify bugs quicker

labels: ["bug"]
---

# Issue Guidelines
Expand All @@ -11,41 +11,11 @@ Before opening a new issue, please take a moment to review our [**community guid
**You may find an answer in already closed issues**:
https://github.com/AniTrend/retrofit-graphql/issues?q=is%3Aissue+is%3Aclosed


## Description Of Bug
<!--- A clear and concise description of what the bug is. -->

__Requests__ not working when using `.gql` files.

**Steps To Reproduce**
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error


## Expected Behavior
<!--- A clear and concise description of what you expect to happen. -->

Perhaps it would be best if anime/manga titles are not truncated


## Screenshots/Videos
<!--- If applicable, add screenshots to help explain your problem. If none of these are available please remove this section alone -->


## Device & Build Information
<!--- Please provide any relevant information about your device. This is important in case the issue is not reproducible except for under certain conditions. -->

* OS Version: Lollipop 5.0.1
* App Version: 1.2.0
* Phone Model: Xperia SP
* Phone Brand: Sony
<!--- A clear and concise description of what the bug is. In other words what is the behaviour -->

## Expected Behaviour
<!--- A clear and concise description of what you expect to happen. This is the intented behaviour -->

## Additional Context
<!--- What are you trying to accomplish? Providing context helps us come up with a solution that is most useful in the real world, also include an logs if you have any in this section -->

I have tested with multiple devices and the issue doesn't seem to be bound to any specific device, OS version or form factor.

I have tested with ......
8 changes: 8 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
blank_issues_enabled: false
contact_links:
- name: 🗣 Ask a Question, Discuss
url: https://github.com/anitrend/retrofit-graphql/discussions
about: General discussion, suggest ideas, share concepts or resources or ask questions, like "How does this work 🤔?"
- name: 🤗 Support the Project
url: https://patreon.com/wax911
about: Support the AniTrend financially.
15 changes: 1 addition & 14 deletions .github/ISSUE_TEMPLATE/feature-request.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Feature Request
about: Got a suggestion? Then this is what you should use

labels: ["feature request"]
---

# Issue Guidelines
Expand All @@ -11,21 +11,8 @@ Before opening a new issue, please take a moment to review our [**community guid
**You may find an answer in already closed issues**:
https://github.com/AniTrend/retrofit-graphql/issues?q=is%3Aissue+is%3Aclosed


## Feature Information
<!-- Is your feature request related to a problem? Please describe. -->

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]


## Solution Information
<!-- Describe the solution you'd like -->

A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.


## Additional context
Add any other context or screenshots about the feature request here.
5 changes: 1 addition & 4 deletions .github/ISSUE_TEMPLATE/question.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Question
about: Ask any general question regarding the project, also if you use this if you don't know what category to use

labels: ["question"]
---

# Issue Guidelines
Expand All @@ -13,9 +13,6 @@ https://github.com/AniTrend/retrofit-graphql/issues?q=is%3Aissue+is%3Aclosed

## Question
<!-- Clearly and explicitly explain the details about your question -->
I would like to know if... I have also searched in the closed issues and...

## Additional Context
<!-- Any additional information regarding your question, you may also add screenshots if any under this section -->

I am currently using...
29 changes: 9 additions & 20 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Pull Request Template

Thank you for contributing! Please take a moment to review our [**contributing guidelines**](https://github.com/AniTrend/retrofit-graphql/blob/master/CONTRIBUTING.md)
Thank you for contributing! Please take a moment to review our [**contributing guidelines**](https://github.com/AniTrend/retrofit-graphql/blob/develop/CONTRIBUTING.md)
to make the process easy and effective for everyone involved.

**Please open an issue** before embarking on any significant pull request, especially those that
Expand All @@ -11,36 +11,25 @@ Before opening a pull request, please ensure:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

- [ ] You have followed our [**contributing guidelines**](https://github.com/AniTrend/retrofit-graphql/blob/master/CONTRIBUTING.md)
- [ ] double-check your branch is based on `develop` and targets `develop`
- [ ] Pull request has tests
- [ ] Code is well-commented, linted and follows project conventions
- [ ] Documentation is updated (if necessary)
- [ ] Description explains the issue/use-case resolved
- [ ] I did not commit files that are excluded in the .gitignore file (Happens if you stage files with Android Studio)
- You have followed our [**contributing guidelines**](https://github.com/AniTrend/retrofit-graphql/blob/develop/CONTRIBUTING.md)
- Double-check your branch is based on `develop` and targets `develop` (where applicable)
- Pull request has tests (If applicable)
- Code is well-commented, linted and follows project conventions
- Documentation is updated (if necessary)
- Description explains the issue/use-case resolved


## Description
<!--- Describe your changes in detail -->

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, tests ran to see how -->
<!--- your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Enhancement (Improve existing functionality)

<!--- Be kind to code reviewers, please try to keep pull requests as small and focused as possible :) -->

**IMPORTANT**: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the [Apache License](https://github.com/AniTrend/retrofit-graphql/blob/master/LICENSE.md).
owners to license your work under the terms of the [Apache License](https://github.com/AniTrend/retrofit-graphql/blob/develop/LICENSE).
34 changes: 0 additions & 34 deletions .github/dependabot.yml

This file was deleted.

71 changes: 71 additions & 0 deletions .github/release-drafter-config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
name-template: 'v$RESOLVED_VERSION'
tag-template: '$RESOLVED_VERSION'
categories:
- title: '🚀 Features'
labels:
- 'feature'
collapse-after: 5
- title: '✨ Improvements'
labels:
- 'enhancement'
collapse-after: 5
- title: '🛠️ Bug Fixes'
labels:
- 'bug fix'
collapse-after: 5
- title: '🧰 Maintenance'
labels:
- 'refactor'
collapse-after: 5
- title: '📦 Dependencies'
labels:
- 'dependencies'
collapse-after: 5
- title: '🔖 Other changes'
autolabeler:
- label: 'docs'
files:
- '*.md'
branch:
- '/docs{0,1}\/.+/'
- label: 'bug fix'
branch:
- '/bugfix\/.+/'
- '/hotfix\/.+/'
- label: 'feature'
branch:
- '/feature\/.+/'
- label: 'enhancement'
branch:
- '/enhancement\/.+/'
- label: 'refactor'
branch:
- '/refactor\/.+/'
- label: 'dependencies'
branch:
- '/dependencies\/.+/'
- '/renovate\/.+/'
change-template: '- $TITLE by @$AUTHOR in #$NUMBER'
change-title-escapes: '\<*_&' # You can add # and @ to disable mentions, and add ` to disable code blocks.
version-resolver:
major:
labels:
- 'breaking'
minor:
labels:
- 'enhancement'
- 'feature'
patch:
labels:
- 'bug fix'
- 'dependencies'
- 'refactor'
default: patch
exclude-labels:
- 'skip-changelog'
template: |
# What's Changed

$CHANGES

**Full Changelog**: https://github.com/$OWNER/$REPOSITORY/compare/$PREVIOUS_TAG...v$RESOLVED_VERSION
85 changes: 85 additions & 0 deletions .github/renovate.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:base"
],
"branchPrefix": "dependencies/",
"reviewers": ["wax911"],
"baseBranches": [
"develop"
],
"packageRules": [
{
"groupName": "Sample Module Dependencies",
"packagePatterns": [
"^androidx\\.activity",
"^androidx\\.fragment",
"^androidx\\.core",
"^androidx\\.constraintlayout",
"^androidx\\.swiperefreshlayout",
"^androidx\\.preference",
"^androidx\\.recyclerview",
"^com\\.google\\.android\\.material",
"^io\\.coil-kt",
"^com\\.github\\.anitrend\\.support-arch",
"^com\\.jakewharton\\.threetenabp",
"^com\\.jakewharton\\.timber"
],
"matchPaths": [
"sample/**"
]
},
{
"groupName": "Room Dependencies",
"packagePatterns": [
"^androidx\\.room"
],
"matchPaths": [
"sample/**"
]
},
{
"groupName": "Paging Dependencies",
"packagePatterns": [
"^androidx\\.paging"
],
"matchPaths": [
"sample/**"
]
},
{
"groupName": "Kotlinx Serialization",
"packagePatterns": [
"^org\\.jetbrains\\.kotlinx\\.serialization"
],
"matchPaths": [
"sample/**"
]
},
{
"groupName": "Koin Dependencies",
"packagePatterns": [
"^org\\.koin"
],
"matchPaths": [
"sample/**"
]
},
{
"groupName": "Testing Dependencies",
"packagePatterns": [
"^junit",
"^io\\.mockk",
"^androidx\\.test",
"^androidx\\.test\\.espresso",
"^androidx\\.test\\.ext"
]
},
{
"groupName": "Jetbrains Dependencies",
"packagePatterns": [
"^org\\.jetbrains\\.kotlin"
]
}
]
}
Loading
Loading