Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add browser examples #405

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add browser examples #405

wants to merge 5 commits into from

Conversation

solidsnakedev
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: 5fc8446

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines 32 to 43
const signBuilder = await lucid
.newTx()
.registerStake(rewardAddress)
.setMinFee(300000n)
.complete();
const signed = await signBuilder.sign.withWallet().complete();
const txHash = await signed.submit();
console.log("txHash :>> ", txHash);
console.log(`🚀 Transaction submitted: ${txHash}`);
console.log(`Confirming Transaction...`);
await lucid.awaitTx(txHash, 40_000);

const vote = await lucid
.newTx()
.delegate.VoteToDRep(rewardAddress, {
__typename: "AlwaysAbstain",
})
.complete();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please consolidate the stake registration, stake delegation and vote delegation in the same transaction (using three different certs)? Sth like:

    // const signBuilder = await lucid
    //   .newTx()
    //   .registerStake(rewardAddress)
    //   .setMinFee(300000n)
    //   .complete();
    // const signed = await signBuilder.sign.withWallet().complete();
    // const txHash = await signed.submit();
    // console.log("txHash :>> ", txHash);
    // console.log(`🚀 Transaction submitted: ${txHash}`);
    // console.log(`Confirming Transaction...`);
    // await lucid.awaitTx(txHash, 40_000);

    const vote = await lucid
      .newTx()
      .register.Stake(stakingAddress.bech32())
      .delegate.ToPool(stakingAddress.bech32(), "pool1k0ucs0fau2vhr3p7qh7mnpfgrllwwda7petxjz2gzzaxkyp8f88")
      .delegate.VoteToDRep(rewardAddress, {
        __typename: "AlwaysAbstain",
      })
      .complete();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants