Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0.0 Major Update #36

Open
wants to merge 76 commits into
base: master
Choose a base branch
from
Open

3.0.0 Major Update #36

wants to merge 76 commits into from

Conversation

moelrobi
Copy link
Member

@moelrobi moelrobi commented Jul 2, 2018

Major Update PR for AminoJS

@moelrobi moelrobi added enhancement New feature or request MajorUpdate All PR's / Issues that are with the latest major Update. MajorUpdatePR All PR's / Issues that indicate the Next Major Update labels Jul 2, 2018
moelrobi and others added 16 commits July 3, 2018 01:27
@moelrobi
Merge pull request #37 from AminoJS/checkin
4df074f 
Unittest
@felixfong227
Add a new index for the getComUsers feature
5895e3d
@felixfong227
Add a new example code for the getComUsers
bb48664
@felixfong227
Add a new URL entry point
2183ba0
@felixfong227
Add a new reference object
c0886ae
@felixfong227
Add a new getComUsers feature
c8564bf
@moelrobi
Merge branch '3.0.0-nightly' into issue38
9e4521b
@moelrobi
Whoopsie Daisy
8818286 
I just forgot an Commata.
@felixfong227
Rename the expored function
7768e36
@felixfong227
Remove the unused variable
87062c8
@felixfong227
Add a new test case for the getComUsers function
ebcefcf
@akatsukilevi
- Finished send new message types
ebd621c 
- Finished framework system(For easier use of the Api)
- Finished favorite members list
- Partially finished Check-In System - Can't check in properly
- Fixed error at getUserBlogs.test.js
@akatsukilevi
Changed only to trigger Travis Build
5bfad63
@akatsukilevi
FIxed Line-Ending And Identination Errors
01caf12
@akatsukilevi
Fixed Git Local Settings To Use CRLF
5a19f75
@akatsukilevi
Changed Line Ending to CRLF
c25cf14
@akatsukilevi
Copy link
Contributor

Hey, any update for merging 3.0.0 to master?

@moelrobi
Copy link
Member Author

moelrobi commented Jan 4, 2019

Once all checks are passing and all methods and endpoints have unit testing, then it will merge into Master. (Prob. Today)

akatsukilevi and others added 3 commits January 4, 2019 08:54
@akatsukilevi
FIx for Unknown option "setTimeout" 1
1880436 
Travis CI is throwing a ``Unknown option "setTimeout" with value 7000 was found. This is probably a typing mistake. Fixing it will remove this message.``exception. Fixed it here

Also had to create a new branch because i edited it directly on GitHub(no ide ready here)
@akatsukilevi
Fix for Unknown option "setTimeout" 2
169c1b6 
Travis CI is throwing a ``Unknown option "setTimeout" with value 7000 was found. This is probably a typing mistake. Fixing it will remove this message.``exception. Fixed it here

Also had to create a new branch because i edited it directly on GitHub(no ide ready here)
Merge pull request #48 from AminoJS/akatsukilevi-patch-travis-package
fa95745 
Note to myself: never Debug again drunk, with only a phone. thanks levi. 👍
@moelrobi
Copy link
Member Author

moelrobi commented Jan 4, 2019 •
edited
Loading

Hey @akatsukilevi,
since i was in the middle of creating tests for the endpoints i stumbbeld upon your getCheckInCommunities Module.

There is this documentation:

/**
 * Loads Favorite Members
 * @param {SecurityString} sid For authenticating with the Narvii-API.
 * @param {String} coms A list of communities to get the check-in status, separated by "&"
 * @param {String} timezone The desired timezone to check(It will affect the user Check-In Functionality)
 * @returns {Object} Object with all the Check In info of the communities specified from the Logged-in User has in an Array.
 */

Couldn't it be easier if the List of communites would be spearated with , and not by &? Why this design choice?

EDIT: Also please keep the Top Documentation clean. I dont think this Module loads favorite Members. >-> xD

@akatsukilevi
Copy link
Contributor

akatsukilevi commented Mar 18, 2019 •
edited
Loading

Hey @akatsukilevi,
since i was in the middle of creating tests for the endpoints i stumbbeld upon your getCheckInCommunities Module.

There is this documentation:

/**
 * Loads Favorite Members
 * @param {SecurityString} sid For authenticating with the Narvii-API.
 * @param {String} coms A list of communities to get the check-in status, separated by "&"
 * @param {String} timezone The desired timezone to check(It will affect the user Check-In Functionality)
 * @returns {Object} Object with all the Check In info of the communities specified from the Logged-in User has in an Array.
 */

Couldn't it be easier if the List of communites would be spearated with , and not by &? Why this design choice?

EDIT: Also please keep the Top Documentation clean. I dont think this Module loads favorite Members. >-> xD

First sorry for take ages to reply XD
Also, it is separated by & instead of , due to the Amino API itself. I can make it be separated by ,, and before send substitute by &, so the API won't fail and the design will get better
What do you think?

EDIT: LOL i didn't noticed that there! XD I'm fixing the Top Documentation now

akatsukilevi
akatsukilevi approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@akatsukilevi akatsukilevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the issue Community Global Config System(#51) Not being finished, it added a lot of things to the repo

@akatsukilevi
Copy link
Contributor

Hey, how's the situation for this pull request?

@akatsukilevi
Update sendImage.js
285fba9 
Added fix to send the image type argument through Amino
@akatsukilevi
Copy link
Contributor

Hey, any update for this merge?

@akatsukilevi akatsukilevi self-requested a review June 25, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfong227 felixfong227 Awaiting requested review from felixfong227

@moelrobii moelrobii Awaiting requested review from moelrobii

@akatsukilevi akatsukilevi Awaiting requested review from akatsukilevi

Assignees

@felixfong227 felixfong227

@moelrobi moelrobi

@akatsukilevi akatsukilevi

Labels
enhancement New feature or request MajorUpdate All PR's / Issues that are with the latest major Update. MajorUpdatePR All PR's / Issues that indicate the Next Major Update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moelrobi @akatsukilevi @felixfong227