Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace router.push with Nextjs Links where appropriate #610

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

johnkahn
Copy link
Contributor

Pre-Requisites

  • Yes, I updated Authors.md OR this is not my first contribution
  • Yes, I included and/or modified tests to cover relevent code OR my change is non-technical
  • Yes, I wrote this code entirely myself OR I properly attributed these changes in Third Party Notices

Description of Changes

Changed router.push uses with the Link component from next/link where it was appropriate

Related Issues

N/A

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3@9d4c237). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             v3     #610   +/-   ##
=====================================
  Coverage      ?   82.89%           
=====================================
  Files         ?      140           
  Lines         ?     1543           
  Branches      ?      161           
=====================================
  Hits          ?     1279           
  Misses        ?      262           
  Partials      ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpencerKaiser SpencerKaiser changed the title Replace router.push with Nextjs Links where appropriate feat: Replace router.push with Nextjs Links where appropriate Nov 28, 2023
@SpencerKaiser SpencerKaiser merged commit 851dffc into AmericanAirlines:v3 Nov 28, 2023
7 checks passed
@johnkahn johnkahn deleted the fix-links branch November 30, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants