AIP#31 impl changes for all crates #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpiel
changed the title
elpiel
commented
Sep 17, 2020
| input.set_ad_view(input::AdView { | ||
| seconds_since_campaign_impression, | ||
| has_custom_preferences: false, | ||
| // TODO: Check this empty default! |
There was a problem hiding this comment.
- Default empty string for
Input::navigator_languageSee: https://github.com/AdExNetwork/adex-validator-stack-rust/blob/7fd8a4b9c39ba9cbb57367c7a90f07823af7643d/adview-manager/src/lib.rs#L329-L330
|
ping @simzzz @samparsky |
…response Issue 337 align channellist response
samparsky
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #312
Partially impls #323 #322 #319
Related #340
TODOs:
adview-manager:
adview-managercratesentry: All tasks moved in favour of #319!
Event aggregator:Check impl of Event AggregatorTest changesEvent Reducer
Check impl of Event ReducerTest changesAnalytic Recorder:
Check impl of Analytics RecorderTests changesget_payout:
get_payout()https://github.com/AdExNetwork/adex-validator/blob/476aecdd64c7e1f535ff7991aeae9c18c045b6db/test/index.js#L359-L364More Tests forMoved to impl AIP#31 changes to Payout #323get_payout()Partially resolves: