Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows code signing #1072

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Windows code signing #1072

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
572b6f8
test code signing
Pombal Oct 11, 2023
c06d93b
Add code signing to Windows builds
Pombal Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/release-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,19 @@ jobs:
# We don't do caching here because we only have 10gb and they'll be occupied by normal builds all the time anyway
- name: Build
run: cargo build --release -p ambient --target ${{ matrix.target }} --features production
- name: Code Sign Windows
if: ${{ matrix.os == 'windows-latest' }}
uses: sslcom/esigner-codesign@develop
with:
command: sign
username: ${{secrets.ES_USERNAME}}
password: ${{secrets.ES_PASSWORD}}
credential_id: ${{secrets.ES_CREDENTIAL_ID}}
totp_secret: ${{secrets.ES_TOTP_SECRET}}
file_path: ${{ env.EXE_DIR }}/${{ matrix.exe_name }}
dir_path: ${{ env.EXE_DIR }}
override: true
malware_block: false
- name: Install certificate (OSX)
if: matrix.os == 'macos-latest'
uses: apple-actions/import-codesign-certs@v1
Expand Down
Loading