Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing retries from classic output. [WIP] #637

Closed
wants to merge 5 commits into from
Closed

Removing retries from classic output. [WIP] #637

wants to merge 5 commits into from

Conversation

antip00
Copy link
Contributor

@antip00 antip00 commented Oct 3, 2024

No description provided.

@Slach Slach self-requested a review October 3, 2024 16:09
Slach
Slach requested changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@Slach Slach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I wrong

But instead of figuring out why our test need retries in this part code of tests, we just change code to remove retries from logs, but still retries?

But this is no sense and smells bad

@Slach Slach added this to the 3.2.4 milestone Oct 3, 2024
@antip00 antip00 changed the title Removing retries from classic output. Removing retries from classic output. [WIP] Oct 11, 2024
@Slach Slach modified the milestones: 3.2.4, 3.3.0 Oct 14, 2024
@antip00 antip00 closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Slach Slach Slach requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@antip00 @Slach