-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Headers in Alerts in golang part #613
Conversation
@Slach I see you active, I wonder if you might be able to take a look at this? |
sorry for late response, failures in e2e test is not related to your PR, to ensure could you merge latest comits from master something like |
688d7aa
to
b3c7c5f
Compare
@Slach it looks like CI is all good now! |
yep, but actually it conflicts with #594 and i don't like implementation about 10 headers |
Aaah, is #594 removing this |
sorry we don't provide any ETA |
I don't know how much overhead releasing a patched version of this go backend would be, but given the go code is going to be entirely replaced in #594 I'd hope we could look past the concerns with this PR
I don't disagree it could be better, but you'll throw it away anyway when you come to merge #594, and I assume that PR when it is finished will include a non 10 restricted implementation. Anyway, looking forward to be able to use this datasource once headers for alerts are supported. |
Should fix #483
I was not able to test this in a development environemtn myself, however the code change si rather straight forward.
Open to ideas to better read the JSON, but ultimately I believe this should work for 99.9% of folks cases and isn;t too ugly.
We could always up the limit from 10 with little effort.
I'd be happy to have #483 resolved!