Updated XMAD calendar for New Years Eve 2021 holiday

AlpacaTechJP · Dec 6, 2021 · bf2cc3a · bf2cc3a
1 parent 71e39aa
commit bf2cc3a
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/exchange_calendars/exchange_calendar_xmad.py b/exchange_calendars/exchange_calendar_xmad.py
@@ -69,8 +69,10 @@
 BoxingDay = boxing_day()
 
 NewYearsEveThrough2010 = new_years_eve(end_date="2011")
-NewYearsEveEarlyClose2012Onwards = new_years_eve(
+NewYearsEveFrom2021 = new_years_eve(start_date="2021")
+NewYearsEveEarlyClose2012To2020 = new_years_eve(
     start_date="2012",
+    end_date="2021",
     days_of_week=(WEEKDAYS),
 )
 
@@ -134,6 +136,7 @@ def regular_holidays(self):
                 Christmas,
                 BoxingDay,
                 NewYearsEveThrough2010,
+                NewYearsEveFrom2021
             ]
         )
 
@@ -145,7 +148,7 @@ def special_closes(self):
                 HolidayCalendar(
                     [
                         ChristmasEveEarlyClose2012To2020,
-                        NewYearsEveEarlyClose2012Onwards,
+                        NewYearsEveEarlyClose2012To2020,
                     ]
                 ),
             )

diff --git a/tests/resources/xmad.csv b/tests/resources/xmad.csv
@@ -8090,7 +8090,6 @@
 2021-12-28T00:00:00Z,2021-12-28T08:00:00Z,2021-12-28T16:30:00Z,,
 2021-12-29T00:00:00Z,2021-12-29T08:00:00Z,2021-12-29T16:30:00Z,,
 2021-12-30T00:00:00Z,2021-12-30T08:00:00Z,2021-12-30T16:30:00Z,,
-2021-12-31T00:00:00Z,2021-12-31T08:00:00Z,2021-12-31T13:00:00Z,,
 2022-01-03T00:00:00Z,2022-01-03T08:00:00Z,2022-01-03T16:30:00Z,,
 2022-01-04T00:00:00Z,2022-01-04T08:00:00Z,2022-01-04T16:30:00Z,,
 2022-01-05T00:00:00Z,2022-01-05T08:00:00Z,2022-01-05T16:30:00Z,,

diff --git a/tests/test_xmad_calendar.py b/tests/test_xmad_calendar.py
@@ -42,7 +42,11 @@ def regular_holidays_sample(self):
             "2004-11-01",  # All Saints Day
             "2004-12-06",  # Constitution Day
             "2004-12-08",  # Immaculate Conception
-            "2010-12-31",  # New Year's Eve
+            #
+            # New Year's Eve was a holiday through to 2010, then became an early
+            # close, and then went back to being a full day's holiday from 2021.
+            "2010-12-31",
+            "2021-12-31"
         ]
 
     @pytest.fixture
@@ -72,7 +76,11 @@ def non_holidays_sample(self):
             "2005-11-01",  # All Saints Day
             "2005-12-06",  # Constitution Day
             "2005-12-08",  # Immaculate Conception
-            "2012-12-31",  # New Year's Eve
+
+            # New Year's Eve was holiday through to 2010, but then became an early
+            # close after that, before becoming a full market holiday again in 2021.
+            "2012-12-31",
+            "2020-12-31"
         ]
 
     @pytest.fixture