Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register the MI unifier for EI #92

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

jpenilla
Copy link
Contributor

Issue Reference

AllTheMods/ATM-10#475

Proposed Changes

EI uses the same item_inputs and item_outputs format for it's recipes as MI. Registering the unifier for EI aims to fix inconsistency between Mixer and Alloy Smelter recipes, as well as allow unifying EI recipes in general.

https://github.com/Swedz/Extended-Industrialization/blob/1.21.1/src/generated/resources/data/extended_industrialization/recipe/materials/cupronickel/alloy_smelter/ingot.json

@rlnt
Copy link
Member

rlnt commented Sep 11, 2024

Thanks for creating this. I didn't know about the existence of this add-on. I will have to check if they add custom recipe types as well and whether all recipe keys are covered by the MI unifier. If not, we need to extend things for the add-on.

@jpenilla
Copy link
Contributor Author

From the devs discord:
image
cc @Swedz

@Swedz
Copy link

Swedz commented Sep 12, 2024

Custom recipe types are added, but they use the same formatting as existing MI recipes. You can see all the machine recipe types I add here.

@rlnt rlnt merged commit f21a5c8 into AlmostReliable:1.21.1 Sep 27, 2024
1 check passed
rlnt pushed a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants