Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

376: Downloads use labkey URL when file is available on Vast #377

Conversation

pgarrison
Copy link
Contributor

@pgarrison pgarrison commented Dec 20, 2024

Cloud-first FMS backend changes and existing updates for them (#370, #375) cause downloads to use the S3 URL. But for files available on the Vast, the download will be faster and use fewer resources if we download from the Vast via the labkey URL http://aics.corp.alleninstitute.org/labkey/fmsfiles/image/allen/...

Closes #376

Testing

  • I added an automated test that confirms the downloadPath has the expected format.
  • I was unable to test this manually. This is because this PR depends on the latest changes to the ETL pipeline, which are only deployed to staging, but downloading files from staging is broken Downloads from FMS staging data source fail with 404 #293 (perhaps it has never worked).

Notes

I believe we should merge this despite being unable to manually test it, because we know that the latest ETL pipeline changes will break the current downloadPath logic.

@pgarrison pgarrison marked this pull request as draft December 20, 2024 19:33
@pgarrison
Copy link
Contributor Author

pgarrison commented Dec 21, 2024

@BrianWhitneyAI To-do: review and merge, after #375 is merged

@kmitcham
Copy link

kmitcham commented Jan 2, 2025

Downloads from staging have been problematic; I suspect files uploaded to staging might work for download, but items uploaded to prod I would be surprised if they downloaded from staging

Base automatically changed from feature/367-canonical-path-is-cloud to feature/local_cloud_toggle January 2, 2025 20:37
@BrianWhitneyAI BrianWhitneyAI merged commit de641da into feature/local_cloud_toggle Jan 2, 2025
7 checks passed
@BrianWhitneyAI BrianWhitneyAI deleted the feature/376-download-via-local-network branch January 2, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants