MIES_AnalysisFunctionPrototypes.ipf: Assert out #2285
Merged
+63
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A prototype function is used for creating function references (FUNCREF). And this also means they are never called. Add an assertion to make that clear and also add some tests.
t-b
force-pushed
the
feature/2285-assert-in-prototype-analysis-functions
branch
from
992643c
to
2d62af6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prototype function is used for creating function references (FUNCREF). And this also means they are never called.
Add an assertion to make that clear and also add some tests.
@timjarsky This should make it clearer that these are not the example analysis functions.
Will merge once CI passes.