ASYNC: Improved error status transfer from workers to main thread #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a thread was aborted through a regular AbortOnValue this was caught but only a possible RTE was evaluated. Thus, the readout function could not determine if the thread was aborted or not. Changes: - The readout function now uses ASYNC_ReadOutStruct as single argument. This allows extensions without changing all function APIs. The structure includes the former values for dfr, RTE code, RTE message and now additionally the V_abortCode. The RTE message must be included here as it has to be retrieved as soon as it happened (in the thread) and needs to be trnasported then to the main thread as well. - The user readout function can evaluate then both error conditions and react accordingly. - Tests
MichaelHuth
force-pushed
the
feature/2256-improve_async_error_handling
branch
from
66a8bae
to
9a0fbf4
Compare
t-b
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a thread was aborted through a regular AbortOnValue this was caught but only a possible RTE was evaluated. Thus, the readout function could not determine if the thread was aborted or not.
Changes:
close #2252