Update JSON XOP #2253
Merged
Update JSON XOP #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-b
previously approved these changes
Sep 4, 2024
|
The failure looks real. |
-one important fix here is the better handling of JSON_AddValue for numbers that can be added as integer.
This test uses PSQ_TEST_VERY_LARGE_FREQUENCY to use a frequency which results in a very large fit slope. The update of the JSON XOP extended the range of valid values, so we also need to use a larger value here. The removed finite check in CheckRangeOfUserLabnotebookKeys is unfortunate but should not be a problem.
t-b
force-pushed
the
feature/2253-update_JSON_XOP
branch
from
09a69dd
to
ce026fa
Compare
|
Fixed the CI failure. It was related to the JSON XOP, but in very edge-case way. |
t-b
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-one important fix here is the better handling of JSON_AddValue
for numbers that can be added as integer.