Allow accessing the logbook waves from ZeroMQ #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
t-b
force-pushed
the
feature/2247-access-to-logbook-from-zeromq
branch
from
15f739c
to
d416bfa
Compare
|
Will merge once CI passes. |
This uses the sorted key waves, forgotten in f3d3f1d (LNB: Change LNB column determination to use a sorted keyWave in the same DF, 2024-06-28).
Most callers currently index into the values wave with dimension labels again, but as we already have the correct index we can just return it.
t-b
force-pushed
the
feature/2247-access-to-logbook-from-zeromq
branch
from
d416bfa
to
6b63781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly I have realized that you can't call a function with a wave argument over zeromq. Until AllenInstitute/ZeroMQ-XOP#60 is fixed, the new function FFI_QueryLogbook allows to query the labnotebook/results waves.