Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend GetSetIntersection to return indices of intersecting elements #2121

Merged
merged 3 commits into from
May 21, 2024

Conversation

MichaelHuth
Copy link
Collaborator

This is useful in an upcoming PR #2109 and probably on other locations.

- new optional argument getIndices that returns indices of the intersecting
  elements of the first wave
- added more tests
  - for getIndices
  - swapped input wave (long/short wave difference)
  - double matching elements
- for text wave input BinarySearchText is used. BinarySearchText does not run a
  bracketing search but an exact search. Thus, an additional test for equality is
  not required.
  Note: The Igor Pro internal BinarySearch function does a bracketed search.
Copy link
Collaborator

@t-b t-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@t-b t-b enabled auto-merge May 21, 2024 12:42
@t-b t-b removed their assignment May 21, 2024
@t-b t-b merged commit 7ec55f9 into main May 21, 2024
20 checks passed
@t-b t-b deleted the feature/2121-extend_getsetintersection branch May 21, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants