fix: fix build

AllayMC · Jan 6, 2025 · da05bc1 · da05bc1
1 parent 1fbf498
commit da05bc1
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 38 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -46,7 +46,7 @@ Unless otherwise specified, any version comparison below is the comparison of se
   `BlockState`.
 - (API) `EntityBaseComponent#getBlockStateStandingOn` now return `BlockStateWithPos` instead of `BlockState`.
 - (API) Removed `BlockFace#horizontalIndex` which is useless.
-- (API) Made `ScoreboardService#ServerEventListener` private as it is not supposed to be touched by plugin.
+- (API) Removed `ScoreboardService#ServerEventListener` as it is not supposed to be touched by plugin.
 - Removed useless class `PackageClassLoaderUtils`, dependency `org.reflections.reflections` is also removed.
 - Added `-dev` suffix to api version in development build.
 

diff --git a/api/src/main/java/org/allaymc/api/scoreboard/ScoreboardService.java b/api/src/main/java/org/allaymc/api/scoreboard/ScoreboardService.java
@@ -4,7 +4,6 @@
 import com.google.common.collect.Sets;
 import lombok.Getter;
 import org.allaymc.api.entity.interfaces.EntityPlayer;
-import org.allaymc.api.eventbus.EventHandler;
 import org.allaymc.api.eventbus.event.entity.EntityDespawnEvent;
 import org.allaymc.api.eventbus.event.player.PlayerJoinEvent;
 import org.allaymc.api.eventbus.event.player.PlayerQuitEvent;
@@ -40,7 +39,34 @@ public final class ScoreboardService {
 
     public ScoreboardService(Server server, ScoreboardStorage storage) {
         this.storage = storage;
-        server.getEventBus().registerListener(new ServerEventListener());
+        var eventBus = server.getEventBus();
+        eventBus.registerListenerFor(EntityDespawnEvent.class, event -> {
+            var entity = event.getEntity();
+            // Do not handle player
+            if (entity instanceof EntityPlayer) return;
+            removeScorerFromAllScoreboards(new EntityScorer(entity));
+        });
+        eventBus.registerListenerFor(PlayerJoinEvent.class, event -> {
+            var player = event.getPlayer();
+            addViewer(player);
+            var scorer = new PlayerScorer(player);
+            scoreboards.values().forEach(scoreboard -> {
+                if (scoreboard.containLine(scorer)) {
+                    viewers.forEach(viewer -> viewer.updateScore(scoreboard.getLine(scorer)));
+                }
+            });
+        });
+        eventBus.registerListenerFor(PlayerQuitEvent.class, event -> {
+            var player = event.getPlayer();
+            if (!player.isInitialized()) return;
+            var scorer = new PlayerScorer(player);
+            scoreboards.values().forEach(scoreboard -> {
+                if (scoreboard.containLine(scorer)) {
+                    viewers.forEach(viewer -> viewer.removeScoreboardLine(scoreboard.getLine(scorer)));
+                }
+            });
+            removeViewer(player);
+        });
     }
 
     public boolean add(Scoreboard scoreboard) {
@@ -145,39 +171,4 @@ public void read() {
     public void removeScorerFromAllScoreboards(Scorer scorer) {
         scoreboards.values().forEach(scoreboard -> scoreboard.removeLine(scorer));
     }
-
-    private class ServerEventListener {
-        @EventHandler
-        public void onEntityDespawn(EntityDespawnEvent event) {
-            var entity = event.getEntity();
-            // Do not handle player
-            if (entity instanceof EntityPlayer) return;
-            removeScorerFromAllScoreboards(new EntityScorer(entity));
-        }
-
-        @EventHandler
-        public void onPlayerJoin(PlayerJoinEvent event) {
-            var player = event.getPlayer();
-            addViewer(player);
-            var scorer = new PlayerScorer(player);
-            scoreboards.values().forEach(scoreboard -> {
-                if (scoreboard.containLine(scorer)) {
-                    viewers.forEach(viewer -> viewer.updateScore(scoreboard.getLine(scorer)));
-                }
-            });
-        }
-
-        @EventHandler
-        public void onPlayerQuit(PlayerQuitEvent event) {
-            var player = event.getPlayer();
-            if (!player.isInitialized()) return;
-            var scorer = new PlayerScorer(player);
-            scoreboards.values().forEach(scoreboard -> {
-                if (scoreboard.containLine(scorer)) {
-                    viewers.forEach(viewer -> viewer.removeScoreboardLine(scoreboard.getLine(scorer)));
-                }
-            });
-            removeViewer(player);
-        }
-    }
 }