Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules.conf: update for Asterisk 22.x.x #468

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Allan-N
Copy link
Collaborator

@Allan-N Allan-N commented Jan 26, 2025

A number of Asterisk modules were deprecated (and removed) in 21.x.x and 22.x.x. These changes update the ASL3 provided "modules.conf" file to sync with those changes as well as some overdue cleanup.

*** NOTE ***
The file currently includes some added content and a bunch of questions. For those reviewing the changes, your comments and guidance are welcomed.

A number of Asterisk modules were deprecated (and removed) in 21.x.x and
22.x.x.  These changes update the ASL3 provided "modules.conf" file to
sync with those changes as well as some overdue cleanup.

*** NOTE ***

The file currently includes some added content and a bunch of questions.
For those reviewing the changes, your comments and guidance is welcomed.
@Allan-N Allan-N self-assigned this Jan 26, 2025
@wd5m
Copy link

wd5m commented Jan 26, 2025

I happened to notice this message in the log. Should or can res_adsi.so be changed to noload now?

[2025-01-26 14:47:24.720] WARNING[730005] loader.c: Module 'res_adsi' has been loaded but may be removed in a future release.

David WD5M

@Allan-N
Copy link
Collaborator Author

Allan-N commented Jan 26, 2025

@wd5m : you have raised a good question.

A quick scan of the Asterisk 22.1.1 sources shows that the following modules would emit that message :

  • app_getcpeid.so
  • app_adsiprog.so
  • app_meetme.so
  • res_adsi.so


; Codecs

load = codec_resample.so
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need these - maybe noload just to have them "visible" if someone needs them?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a bunch of dups here. The only 2 remaining are codec_resample.so and codec_g722.so


; Applications

load = app_bridgewait.so
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking noload so they are visible. POI:we use confbridge on our hub so maybe others use it too?


load = func_callerid.so ; Party ID related dialplan functions (Cal
load = func_cdr.so ; Call Detail Record (CDR) dialplan functi
load = func_strings.so
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have noload func_strings.so - maybe that is wrong?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This func_strings.so was a dup from our previous modules.conf file. But, the question of noload vs. load is one to ask (ASL3 "no" or Asterisk "yes")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that function should be enabled.

configs/rpt/modules.conf Outdated Show resolved Hide resolved

[global]

load = res_http_websocket.so
Copy link
Collaborator

@mkmer mkmer Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the need for these. Maybe others do? noload websocket & musiconhold

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

res_musiconhold was a dup here (but it was a noload).
res_http_websocket is a Q

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we are using websockets.

Updated/added module descriptions
@Allan-N Allan-N linked an issue Jan 29, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load bridge_simple by default
5 participants