refactor: Update get_github_installation_ids to use httpx #6451
+9
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
get_github_installation_ids
function to usehttpx
instead ofrequests
withcall_sync_from_async
. This change makes the code more consistent with other functions in the file and more efficient by using native async HTTP requests.Changes:
requests
withhttpx.AsyncClient()
httpx.HTTPError
response.close()
as it is handled by the context managerTo run this PR locally, use the following command: