Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use None check instead of falsy #4705

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

ryanhoangt
Copy link
Contributor

@ryanhoangt ryanhoangt commented Nov 2, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

  • Use None check instead of falsy for parameter validation. Original PR: here

Link of any specific issues this addresses

@enyst enyst requested a review from xingyaoww November 2, 2024 11:27
@enyst
Copy link
Collaborator

enyst commented Nov 2, 2024

Nice catch, thank you! Xingyao may want to take a look.

Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

openhands/runtime/plugins/agent_skills/file_editor/impl.py Outdated Show resolved Hide resolved
@ryanhoangt ryanhoangt changed the title fix: use None check instead of falsy and add upper-bound for snippet fix: use None check instead of falsy Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants